Re: automatic restore point - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: automatic restore point
Date
Msg-id 20180930124510.GB1763@paquier.xyz
Whole thread Raw
In response to Re: automatic restore point  (Peter Eisentraut <peter.eisentraut@2ndquadrant.com>)
Responses Re: automatic restore point  (Alvaro Herrera <alvherre@2ndquadrant.com>)
List pgsql-hackers
On Fri, Sep 28, 2018 at 09:13:17PM +0200, Peter Eisentraut wrote:
> I think this should be done using event triggers.  Right now, you just
> have it hardcoded to TRUNCATE and DROP TABLE, which seems somewhat
> arbitrary.  With event triggers, you have the full flexibility to do
> what you want.  You can pick which commands to apply it to, you can log
> the LSN, you can create restore points, etc.

I still unfortunately don't see what this patch brings more that you
cannot do.  Event triggers are particularly useful in this prospective,
so I am marking the patch as rejected.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Use durable_unlink for .ready and .done files for WAL segmentremoval
Next
From: Michael Paquier
Date:
Subject: Re: [Patch] Create a new session in postmaster by calling setsid()