Re: auto_explain: Include JIT output if applicable - Mailing list pgsql-hackers

From Andres Freund
Subject Re: auto_explain: Include JIT output if applicable
Date
Msg-id 20180929051110.sv65qp5pigawhvhg@alap3.anarazel.de
Whole thread Raw
In response to RE: auto_explain: Include JIT output if applicable  ("Shinoda, Noriyoshi (PN Japan GCS Delivery)" <noriyoshi.shinoda@hpe.com>)
Responses RE: auto_explain: Include JIT output if applicable  ("Shinoda, Noriyoshi (PN Japan GCS Delivery)" <noriyoshi.shinoda@hpe.com>)
List pgsql-hackers
Hi,

On 2018-09-29 05:04:25 +0000, Shinoda, Noriyoshi (PN Japan GCS Delivery) wrote:
> I tried this feature.
> I think that 'if (es->costs)' of the source code auto_explain.c will always be ‘true’.
> 
> Because it is not changed after 'es-> cost = true' in NewExplainState () function several rows ago.
> So I attached a patch to delete this if statement.

I think it's better to stay closer to what explain.c itself is doing -
it's not like that if statement costs us anything really...

- Andres


pgsql-hackers by date:

Previous
From: "Shinoda, Noriyoshi (PN Japan GCS Delivery)"
Date:
Subject: RE: auto_explain: Include JIT output if applicable
Next
From: "Shinoda, Noriyoshi (PN Japan GCS Delivery)"
Date:
Subject: RE: auto_explain: Include JIT output if applicable