Postgres Pro
Downloads
Home   >   mailing lists

Re: Segfault when creating partition with a primary key and sql_droptrigger exists - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Segfault when creating partition with a primary key and sql_droptrigger exists
Date
Msg-id 20180926033324.GH1659@paquier.xyz
Whole thread Raw
In response to Re: Segfault when creating partition with a primary key and sql_droptrigger exists  (Dmitry Dolgov <9erthalion6@gmail.com>)
Responses Re: Segfault when creating partition with a primary key and sql_droptrigger exists  (Dmitry Dolgov <9erthalion6@gmail.com>)
List pgsql-hackers
Tree view 
On Tue, Sep 25, 2018 at 01:39:59PM +0200, Dmitry Dolgov wrote:
> Shouldn't it be fixed by adding EventTriggerAlterTableStart? Judging from the
> following call of ATController, we can just pass NULL as parsetree.

Hmm.  I don't think that this is correct as this data could always be
used to fetch a command tag, right?  It seems to me instead that we
should pass down IndexStmt and handle things like the attached.
Thoughts?
--
Michael
Attachment

pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: pgsql: Remove absolete function TupleDescGetSlot().
Next
From: Michael Paquier
Date:
Subject: Re: pgsql: Remove absolete function TupleDescGetSlot().