Re: Revoke execution permission of pg_stat_statements_reset() frompg_read_all_stats role - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Revoke execution permission of pg_stat_statements_reset() frompg_read_all_stats role
Date
Msg-id 20180925005807.GB1354@paquier.xyz
Whole thread Raw
In response to Re: Revoke execution permission of pg_stat_statements_reset() from pg_read_all_stats role  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Revoke execution permission of pg_stat_statements_reset() frompg_read_all_stats role  (Haribabu Kommi <kommi.haribabu@gmail.com>)
List pgsql-hackers
On Mon, Sep 24, 2018 at 12:02:35PM -0400, Tom Lane wrote:
> For v10 and up, the method used in 53b79ab4 is overcomplicated: you only
> need to add a delta script not a new base script.  (If you had to
> back-patch before v10, it might be best to add a new base script in all
> the branches just to keep the patches consistent; but IIUC this issue only
> arises in v10 and up.)  I'd consider following, eg, 7f563c09f as a
> prototype instead.

Of course, thanks.  Sorry for the incorrect reference pointing to a
commit of REL9_6_STABLE.  As the patch only needs to be applied down to
v10, there is no need to do anything more complicated than what Hari has
proposed.  So, committed after a bit of comment and format tweaks.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Andrew Gierth
Date:
Subject: Re: Implementing SQL ASSERTION
Next
From: Michael Paquier
Date:
Subject: Re: Proposal for Signal Detection Refactoring