Re: Proposal for Signal Detection Refactoring - Mailing list pgsql-hackers

From Andres Freund
Subject Re: Proposal for Signal Detection Refactoring
Date
Msg-id 20180921045218.plds5jh7zyjoqvvq@alap3.anarazel.de
Whole thread Raw
In response to Re: Proposal for Signal Detection Refactoring  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
On 2018-09-21 13:46:11 +0900, Michael Paquier wrote:
> On Thu, Sep 20, 2018 at 03:08:34PM +0200, Chris Travers wrote:
> > So here's a small patch.  I will add it for the next commit fest unless
> > anyone has any reason I shouldn't.
> 
> -       return InterruptPending && (QueryCancelPending || ProcDiePending);
> +       return PENDING_INTERRUPT_LEVEL() >= QUERY_CANCEL;
> 
> This is pretty similar to lock levels, where it is pretty hard to put a
> strict monotone hierarchy when it comes to such interruptions.

+1

Greetings,

Andres Freund


pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Proposal for Signal Detection Refactoring
Next
From: Michael Paquier
Date:
Subject: Re: transction_timestamp() inside of procedures