Re: Changing the setting of wal_sender_timeout per standby - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Changing the setting of wal_sender_timeout per standby
Date
Msg-id 20180919061303.GB19808@paquier.xyz
Whole thread Raw
In response to Re: Changing the setting of wal_sender_timeout per standby  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
On Wed, Sep 19, 2018 at 02:40:31PM +0900, Michael Paquier wrote:
> Parameters classified as PGC_BACKEND can be updated by any users, and
> those marked as PGC_SU_BACKEND can only be updated by superusers.
> Replication users are not superusers, which is why PGC_BACKEND is most
> adapted.  Your description should just say "This parameter cannot be
> changed after session start.

Actually, now that I look at guc.c, using PGC_BACKEND breaks one case:
such parameter types cannot be changed even with SIGHUP, and this even
if the session relies on the default value.  So you could break
applications relying on reloads.  PGC_USERSET would actually do the work
as if the session uses a non-default value specified by SET or within
the connection string, then SIGHUP updates have no effect.  On the
contrary, if the client relies on the default value, then SIGHUP updates
take effect.  Sorry for the confusion, I should have looked at guc.c
more carefully.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Edmund Horner
Date:
Subject: Re: Tid scan improvements
Next
From: "Tsunakawa, Takayuki"
Date:
Subject: RE: Changing the setting of wal_sender_timeout per standby