Re: pg_verify_checksums -d option (was: Re: pg_verify_checksums -roption) - Mailing list pgsql-hackers

From Yugo Nagata
Subject Re: pg_verify_checksums -d option (was: Re: pg_verify_checksums -roption)
Date
Msg-id 20180830173509.5905d868f273364b3e9bfc39@sraoss.co.jp
Whole thread Raw
In response to Re: pg_verify_checksums -d option (was: Re: pg_verify_checksums -roption)  (Michael Banck <michael.banck@credativ.de>)
Responses Re: pg_verify_checksums -d option (was: Re: pg_verify_checksums -roption)
List pgsql-hackers
On Thu, 30 Aug 2018 10:13:31 +0200
Michael Banck <michael.banck@credativ.de> wrote:

> Hi,
> 
> thanks for fixing this up!
> 
> On Wed, Aug 29, 2018 at 11:25:28PM +0900, Yugo Nagata wrote:
> > diff --git a/doc/src/sgml/ref/pg_verify_checksums.sgml b/doc/src/sgml/ref/pg_verify_checksums.sgml
> > index ecc5501eae..a1ff060c2b 100644
> > --- a/doc/src/sgml/ref/pg_verify_checksums.sgml
> > +++ b/doc/src/sgml/ref/pg_verify_checksums.sgml
> > @@ -64,8 +64,8 @@ PostgreSQL documentation
> >        <term><option>-d</option></term>
> 
> This -d needs to be renamed to -v as well I guess.
> 
> >        <listitem>
> >         <para>
> > -        Enable debug output. Lists all checked blocks and their checksum.
> > -       </para>
> > +        Enable debug output. Lists all checked files.
> 
> I'd say 'Enable verbose output.' would be more appropriate now.
> 
> Looks good to me otherwise.

Thank you for your review. I forgot the doc fix.
Attached is the updated patch.

Regards,
-- 
Yugo Nagata <nagata@sraoss.co.jp>

Attachment

pgsql-hackers by date:

Previous
From: Michael Banck
Date:
Subject: pg_verify_checksums and -fno-strict-aliasing
Next
From: Yugo Nagata
Date:
Subject: Re: pg_verify_checksums -d option (was: Re: pg_verify_checksums -roption)