Re: BUG #15347: Unaccent for greek characters does not work - Mailing list pgsql-bugs

From Michael Paquier
Subject Re: BUG #15347: Unaccent for greek characters does not work
Date
Msg-id 20180824113508.GI30782@paquier.xyz
Whole thread Raw
In response to Re: BUG #15347: Unaccent for greek characters does not work  (Thomas Munro <thomas.munro@enterprisedb.com>)
Responses Re: BUG #15347: Unaccent for greek characters does not work  (Thomas Munro <thomas.munro@enterprisedb.com>)
List pgsql-bugs
On Fri, Aug 24, 2018 at 03:32:28PM +1200, Thomas Munro wrote:
> Ok, 2 against 1.  Done.

Thanks for considering it.  I have not gone in details through the patch
but...

+           (codepoint.id >= ord('A') and codepoint.id <= ord('Z')) or \
+           (codepoint.id >= 0x03b1 and codepoint.id <= 0x03c9) or \
+           (codepoint.id >= 0x0391 and codepoint.id <= 0x03a9)

...  If you could add notes about what those codepoints are, or just
allocate them in a variable with a proper name, that would help with the
readability.  My apologies for the nits on this thread.
--
Michael

Attachment

pgsql-bugs by date:

Previous
From: PG Bug reporting form
Date:
Subject: BUG #15349: "make installcheck -C src/interfaces/libpq" fails
Next
From: PG Bug reporting form
Date:
Subject: BUG #15350: Getting invalid cache ID: 11 Errors