Re: [FEATURE PATCH] pg_stat_statements with plans (v02) - Mailing list pgsql-hackers

From Andres Freund
Subject Re: [FEATURE PATCH] pg_stat_statements with plans (v02)
Date
Msg-id 20180820092614.lbax54ejljxtaxga@alap3.anarazel.de
Whole thread Raw
In response to Re: [FEATURE PATCH] pg_stat_statements with plans (v02)  (Thomas Munro <thomas.munro@enterprisedb.com>)
Responses Re: [FEATURE PATCH] pg_stat_statements with plans (v02)
List pgsql-hackers
Hi,

On 2018-08-20 15:21:07 +1200, Thomas Munro wrote:
> On Mon, Aug 20, 2018 at 2:55 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> > Thomas Munro <thomas.munro@enterprisedb.com> writes:
> > ... but I'm less excited about this one.  Seems like a great opportunity
> > for unexpected stack overflows, and thence at least the chance for
> > DOS-causing security attacks.  Can we prevent that from being allowed,
> > if we start using -std=c99?
> 
> -Werror=vla in GCC, apparently.

How about detecting support for that in our configure script and
automatically using it?  If we're uncomfortable with raising an error,
let's at least raise a warning?

- Andres


pgsql-hackers by date:

Previous
From: Amit Langote
Date:
Subject: Re: partitioning - changing a slot's descriptor is expensive
Next
From: Peter Eisentraut
Date:
Subject: Re: remove ATTRIBUTE_FIXED_PART_SIZE