On Mon, Aug 13, 2018 at 02:56:16AM -0700, Andres Freund wrote:
> On 2018-08-09 18:50:47 +0200, Michael Paquier wrote:
> I don't think that comment, nor the comment that you ended up
> committing:
> +
> + /*
> + * Reset the temporary namespace flag in MyProc. We assume that
> + * this operation is atomic. Even if it is not, the temporary
> + * table which created this namespace is still locked until this
> + * transaction aborts so it would not be visible yet, acting as a
> + * barrier.
> + */
>
> is actually correct. *Holding* a lock isn't a memory barrier. Acquring
> or releasing one is.
I cannot guess what you think, but would something like the attached be
more adapted? Both things look rather similar to me now, likely for you
it does not.
--
Michael
