A dubious message related to SP-GiST compress method. - Mailing list pgsql-hackers

From Kyotaro HORIGUCHI
Subject A dubious message related to SP-GiST compress method.
Date
Msg-id 20180810.100742.15469435.horiguchi.kyotaro@lab.ntt.co.jp
Whole thread Raw
List pgsql-hackers
I ran across the followin gcode in spgutils.c.

>     if (OidIsValid(cache->config.leafType) &&
>       cache->config.leafType != atttype)
>     {
>       if (!OidIsValid(index_getprocid(index, 1, SPGIST_COMPRESS_PROC)))
>         ereport(ERROR,
>             (errcode(ERRCODE_INVALID_PARAMETER_VALUE),
>              errmsg("compress method must not defined when leaf type is different from input type")));
>       fillTypeDesc(&cache->attLeafType, cache->config.leafType);

IIUC the fourth line looks inconsistent with the message in 7th
line. Compress methos is required in the case. Isn't "must not
defined" a typo of "must be defined"?

regards.

-- 
Kyotaro Horiguchi
NTT Open Source Software Center
diff --git a/src/backend/access/spgist/spgutils.c b/src/backend/access/spgist/spgutils.c
index 4a9b5da268..6d59b316ae 100644
--- a/src/backend/access/spgist/spgutils.c
+++ b/src/backend/access/spgist/spgutils.c
@@ -133,7 +133,7 @@ spgGetCache(Relation index)
             if (!OidIsValid(index_getprocid(index, 1, SPGIST_COMPRESS_PROC)))
                 ereport(ERROR,
                         (errcode(ERRCODE_INVALID_PARAMETER_VALUE),
-                         errmsg("compress method must not defined when leaf type is different from input type")));
+                         errmsg("compress method must be defined when leaf type is different from input type")));
 
             fillTypeDesc(&cache->attLeafType, cache->config.leafType);
         }

pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: POC for a function trust mechanism
Next
From: Andrew Dunstan
Date:
Subject: Re: PATCH: pgbench - option to build using ppoll() for largerconnection counts