Documentaion fix. - Mailing list pgsql-hackers

From Kyotaro HORIGUCHI
Subject Documentaion fix.
Date
Msg-id 20180731.190909.42582169.horiguchi.kyotaro@lab.ntt.co.jp
Whole thread Raw
Responses Re: Documentaion fix.  (Alvaro Herrera <alvherre@2ndquadrant.com>)
List pgsql-hackers
Hello.

I found that an example output in the following page is not
correct for the version.

https://www.postgresql.org/docs/10/static/warm-standby.html

postgres=# SELECT * FROM pg_replication_slots;
>   slot_name  | slot_type | datoid | database | active | xmin | restart_lsn | confirmed_flush_lsn
> -------------+-----------+--------+----------+--------+------+-------------+---------------------
>  node_a_slot | physical  |        |          | f      |      |             |

The correct one is

>   slot_name  | plugin | slot_type | datoid | database | temporary | active | active_pid | xmin | catalog_xmin |
restart_lsn| confirmed_flush_lsn 
 
>
-------------+--------+-----------+--------+----------+-----------+--------+------------+------+--------------+-------------+---------------------
>  node_a_slot |        | physical  |        |          | f         | f      |            |      |              |
     | 
 

From 9.4, 9.5, 9.6 and 10 and later have an example output wrong
in individual way of the version. I'm not sure how the
documentation was updated but each of the attached patches fixes
the version designated in the file name.

But, just fixing it makes the line seemingly a bit too long..

regards.

-- 
Kyotaro Horiguchi
NTT Open Source Software Center
From 93c69b9cccaf527fdfe765cfe9b9e88ee86f226c Mon Sep 17 00:00:00 2001
From: Kyotaro Horiguchi <horiguchi.kyotaro@lab.ntt.co.jp>
Date: Tue, 31 Jul 2018 18:38:03 +0900
Subject: [PATCH] Documentation fix of "Log-Shipping Standy Servers" for 9.4.

The example output of pg_replication_slot is stale. Replaces with the
up-to-date example.
---
 doc/src/sgml/high-availability.sgml | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/doc/src/sgml/high-availability.sgml b/doc/src/sgml/high-availability.sgml
index cd5305620d..fce09f1799 100644
--- a/doc/src/sgml/high-availability.sgml
+++ b/doc/src/sgml/high-availability.sgml
@@ -932,9 +932,9 @@ postgres=# SELECT * FROM pg_create_physical_replication_slot('node_a_slot');
  node_a_slot |
 
 postgres=# SELECT * FROM pg_replication_slots;
-  slot_name  | slot_type | datoid | database | active | xmin | restart_lsn
--------------+-----------+--------+----------+--------+------+-------------
- node_a_slot | physical  |        |          | f      |      |
+  slot_name  | plugin | slot_type | datoid | database | active | xmin | catalog_xmin | restart_lsn 
+-------------+--------+-----------+--------+----------+--------+------+--------------+-------------
+ node_a_slot |        | physical  |        |          | f      |      |              | 
 (1 row)
 </programlisting>
      To configure the standby to use this slot, <varname>primary_slot_name</>
-- 
2.16.3

From eba78232e51bed3a4dc3fca6e311ece191d163cd Mon Sep 17 00:00:00 2001
From: Kyotaro Horiguchi <horiguchi.kyotaro@lab.ntt.co.jp>
Date: Tue, 31 Jul 2018 18:33:20 +0900
Subject: [PATCH] Documentation fix of "Log-Shipping Standy Servers" for 9.5.

The example output of pg_replication_slot is stale. Replaces with the
up-to-date example.
---
 doc/src/sgml/high-availability.sgml | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/doc/src/sgml/high-availability.sgml b/doc/src/sgml/high-availability.sgml
index 35daf0103a..780851c976 100644
--- a/doc/src/sgml/high-availability.sgml
+++ b/doc/src/sgml/high-availability.sgml
@@ -932,9 +932,9 @@ postgres=# SELECT * FROM pg_create_physical_replication_slot('node_a_slot');
  node_a_slot |
 
 postgres=# SELECT * FROM pg_replication_slots;
-  slot_name  | slot_type | datoid | database | active | xmin | restart_lsn
--------------+-----------+--------+----------+--------+------+-------------
- node_a_slot | physical  |        |          | f      |      |
+  slot_name  | plugin | slot_type | datoid | database | active | active_pid | xmin | catalog_xmin | restart_lsn 
+-------------+--------+-----------+--------+----------+--------+------------+------+--------------+-------------
+ node_a_slot |        | physical  |        |          | f      |            |      |              | 
 (1 row)
 </programlisting>
      To configure the standby to use this slot, <varname>primary_slot_name</>
-- 
2.16.3

From 8a97a8defc674a03dc63c93439430d88278335cf Mon Sep 17 00:00:00 2001
From: Kyotaro Horiguchi <horiguchi.kyotaro@lab.ntt.co.jp>
Date: Tue, 31 Jul 2018 18:29:57 +0900
Subject: [PATCH] Documentation fix of "Log-Shipping Standy Servers" for 9.6.

The example output of pg_replication_slot is stale. Replaces with the
up-to-date example.
---
 doc/src/sgml/high-availability.sgml | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/doc/src/sgml/high-availability.sgml b/doc/src/sgml/high-availability.sgml
index a52580e3dd..ab6d146b68 100644
--- a/doc/src/sgml/high-availability.sgml
+++ b/doc/src/sgml/high-availability.sgml
@@ -932,9 +932,9 @@ postgres=# SELECT * FROM pg_create_physical_replication_slot('node_a_slot');
  node_a_slot |
 
 postgres=# SELECT * FROM pg_replication_slots;
-  slot_name  | slot_type | datoid | database | active | xmin | restart_lsn | confirmed_flush_lsn
--------------+-----------+--------+----------+--------+------+-------------+---------------------
- node_a_slot | physical  |        |          | f      |      |             |
+  slot_name  | plugin | slot_type | datoid | database | active | active_pid | xmin | catalog_xmin | restart_lsn |
confirmed_flush_lsn
 

+-------------+--------+-----------+--------+----------+--------+------------+------+--------------+-------------+---------------------
+ node_a_slot |        | physical  |        |          | f      |            |      |              |             | 
 (1 row)
 </programlisting>
      To configure the standby to use this slot, <varname>primary_slot_name</>
-- 
2.16.3

From 79e433a81fa84feb597cec5da3a049ab355327b4 Mon Sep 17 00:00:00 2001
From: Kyotaro Horiguchi <horiguchi.kyotaro@lab.ntt.co.jp>
Date: Tue, 31 Jul 2018 18:44:18 +0900
Subject: [PATCH] Documentation fix of "Log-Shipping Standy Servers" for devel.

The example output of pg_replication_slot is stale. Replaces with the
up-to-date example.
---
 doc/src/sgml/high-availability.sgml | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/doc/src/sgml/high-availability.sgml b/doc/src/sgml/high-availability.sgml
index 934eb9052d..bd2747de25 100644
--- a/doc/src/sgml/high-availability.sgml
+++ b/doc/src/sgml/high-availability.sgml
@@ -967,9 +967,9 @@ postgres=# SELECT * FROM pg_create_physical_replication_slot('node_a_slot');
  node_a_slot |
 
 postgres=# SELECT * FROM pg_replication_slots;
-  slot_name  | slot_type | datoid | database | active | xmin | restart_lsn | confirmed_flush_lsn
--------------+-----------+--------+----------+--------+------+-------------+---------------------
- node_a_slot | physical  |        |          | f      |      |             |
+  slot_name  | plugin | slot_type | datoid | database | temporary | active | active_pid | xmin | catalog_xmin |
restart_lsn| confirmed_flush_lsn 
 

+-------------+--------+-----------+--------+----------+-----------+--------+------------+------+--------------+-------------+---------------------
+ node_a_slot |        | physical  |        |          | f         | f      |            |      |              |
    | 
 
 (1 row)
 </programlisting>
      To configure the standby to use this slot, <varname>primary_slot_name</varname>
-- 
2.16.3


pgsql-hackers by date:

Previous
From: "Yamaji, Ryo"
Date:
Subject: RE: [HACKERS] Cached plans and statement generalization
Next
From: Yugo Nagata
Date:
Subject: Re: Fw: Windows 10 got stuck with PostgreSQL at starting up. Addingdelay lets it avoid.