Re: 11beta crash/assert caused by parameter type changes - Mailing list pgsql-hackers

From Andres Freund
Subject Re: 11beta crash/assert caused by parameter type changes
Date
Msg-id 20180726192748.lxig45jdmpbbqhr3@alap3.anarazel.de
Whole thread Raw
In response to Re: 11beta crash/assert caused by parameter type changes  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: 11beta crash/assert caused by parameter type changes
List pgsql-hackers
Hi,

On 2018-07-26 14:06:16 -0400, Tom Lane wrote:
> I was about to add Andrew's example as a test case (also shown in
> attached), but realized that there's a problem: just as noted in
> the similar test for named-composite-type changes a bit above there,
> the failure fails to fail in CLOBBER_CACHE_ALWAYS builds.  We'd decided
> to just omit that test (cf feb1cc559) but having been embarrassed by
> this crash I'm feeling like we really could do with some test coverage.
> I'm tempted to extract the affected test cases into their own small
> test script and provide two variant expected files, one for normal and
> one for CLOBBER_CACHE_ALWAYS builds.  Thoughts?

Could we perhaps avoid the divergence by prevent a replan, e.g. by using
a cursor and starting the execution of the query before changing the
type?  Otherwise I think I'm ok with having an alternative file, as long
as there's a good comment explaining it.

-Andres


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: 11beta crash/assert caused by parameter type changes
Next
From: Tom Lane
Date:
Subject: Re: 11beta crash/assert caused by parameter type changes