Re: Non-portable shell code in pg_upgrade tap tests - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Non-portable shell code in pg_upgrade tap tests
Date
Msg-id 20180723033936.GH2854@paquier.xyz
Whole thread Raw
In response to Re: Non-portable shell code in pg_upgrade tap tests  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Non-portable shell code in pg_upgrade tap tests  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Sun, Jul 22, 2018 at 02:53:51PM -0400, Tom Lane wrote:
> Oh!  Hm, I wonder whether we shouldn't do that, ie add SHELL = @SHELL@
> to Makefile.global.in.

That sounds like a good idea to me.

> A quick trawl of the buildfarm logs says most of our animals compute
> SHELL = /bin/sh anyway, and so would be unaffected.  There's a sizable
> population that find /bin/bash though, and one active critter that finds
> /bin/ksh.

Except for the FreeBSD boxes, right?  I thought that using directly
/bin/ and not /usr/local/bin/ was considered an abuse of Linux in their
universe.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: pgbench: improve --help and --version parsing
Next
From: Thomas Munro
Date:
Subject: Re: Possible performance regression in version 10.1 with pgbenchread-write tests.