Re: pgsql: Deduplicate "invalid input syntax" messages for varioustypes. - Mailing list pgsql-committers

From Andres Freund
Subject Re: pgsql: Deduplicate "invalid input syntax" messages for varioustypes.
Date
Msg-id 20180723005336.4ey7pyjkmgc3pcec@alap3.anarazel.de
Whole thread Raw
In response to Re: pgsql: Deduplicate "invalid input syntax" messages for varioustypes.  (Michael Paquier <michael@paquier.xyz>)
Responses Re: pgsql: Deduplicate "invalid input syntax" messages for varioustypes.
List pgsql-committers
On 2018-07-23 09:49:58 +0900, Michael Paquier wrote:
> On Sun, Jul 22, 2018 at 10:30:20PM +0000, Andres Freund wrote:
> > Deduplicate "invalid input syntax" messages for various types.
> > 
> > Previously a lot of the error messages referenced the type in the
> > error message itself. That requires that the message is translated
> > separately for each type.
> > 
> > Note that currently a few smallint cases continue to reference the
> > integer, rather than smallint, type. A later patch will create a
> > separate routine for 16bit input.
> 
> A couple of alternate outputs have been forgotten here (int8 has some
> extra ones), causing make check to turn red on Windows, and plcheck to
> turn red on macos.

Yea, I noticed. I pushed a blind fix. Hope that fixes it, but I'll
re-check. Took me a while because I had to re-run check-world a couple
times because you continued to push things ;)

Greetings,

Andres Freund


pgsql-committers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: pgsql: Deduplicate "invalid input syntax" messages for varioustypes.
Next
From: Michael Paquier
Date:
Subject: Re: pgsql: Deduplicate "invalid input syntax" messages for varioustypes.