Re: Non-reserved replication slots and slot advancing - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Non-reserved replication slots and slot advancing
Date
Msg-id 20180710082932.GM1661@paquier.xyz
Whole thread Raw
In response to Re: Non-reserved replication slots and slot advancing  (Andres Freund <andres@anarazel.de>)
Responses Re: Non-reserved replication slots and slot advancing  (Alvaro Herrera <alvherre@2ndquadrant.com>)
List pgsql-hackers
On Tue, Jul 10, 2018 at 01:16:30AM -0700, Andres Freund wrote:
> On 2018-07-10 16:59:07 +0900, Michael Paquier wrote:
> >      if (moveto < minlsn)
> > -    {
> > -        ReplicationSlotRelease();
> >          ereport(ERROR,
> >                  (errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
> > -                 errmsg("cannot move slot to %X/%X, minimum is %X/%X",
> > +                 errmsg("cannot advance replication slot to %X/%X, minimum is %X/%X",
> >                          (uint32) (moveto >> 32), (uint32) moveto,
> >                          (uint32) (minlsn >> 32), (uint32) minlsn)));
> > -    }
>
> If you're touching this, I'd also change the errcode here.

Yep, let's change that as well.  If you want to look at that stuff more
deeply, please feel free.  Otherwise I could always push what I have
now.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Julien Rouhaud
Date:
Subject: Re: [Tiny Debug Issue] Undefined Reference problem encountered during compile
Next
From: "Tsunakawa, Takayuki"
Date:
Subject: RE: How can we submit code patches that implement our (pending)patents?