Re: pgsql: Add wait event for fsync of WAL segments - Mailing list pgsql-committers

From Alvaro Herrera
Subject Re: pgsql: Add wait event for fsync of WAL segments
Date
Msg-id 20180709182433.wysgm7rizw2xkp4i@alvherre.pgsql
Whole thread Raw
In response to Re: pgsql: Add wait event for fsync of WAL segments  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: pgsql: Add wait event for fsync of WAL segments
List pgsql-committers
On 2018-Jul-09, Tom Lane wrote:

> Michael Paquier <michael@paquier.xyz> writes:
> > On Sun, Jul 08, 2018 at 10:23:37PM +0200, Julien Rouhaud wrote:
> >> I just noticed that the number of rows for the IO wait event type
> >> documentation hasn't been updated, see
> >> https://www.postgresql.org/docs/devel/static/monitoring-stats.html#WAIT-EVENT-TABLE.
> >> Trivial patch attached.
> 
> > Thanks, Julien!  Fixed.  Indeed the table format was weird..
> 
> Hm, do we need that "morerows" thing at all?  It seems impossible
> that we'll remember to keep it up to date in future.  How do you
> even check that it's right now?

Maybe we should add an XML comment
<!-- remember to update "morerows" above -->
at the end of the table :-)

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


pgsql-committers by date:

Previous
From: Bruce Momjian
Date:
Subject: pgsql: rel notes: mention enabling of parallelism in PG 10
Next
From: Tom Lane
Date:
Subject: pgsql: Fix yet more problems with incorrectly-constructed zero-lengtha