Re: Tips on committing - Mailing list pgsql-hackers

From Stephen Frost
Subject Re: Tips on committing
Date
Msg-id 20180702160546.GB27724@tamriel.snowman.net
Whole thread Raw
In response to Re: Tips on committing  (Peter Geoghegan <pg@bowt.ie>)
Responses Re: Tips on committing  (Alvaro Herrera <alvherre@2ndquadrant.com>)
Re: Tips on committing  (Alvaro Herrera <alvherre@2ndquadrant.com>)
List pgsql-hackers
Greetings,

* Peter Geoghegan (pg@bowt.ie) wrote:
> FWIW, I developed a document on committing for my own reference, with
> some help from Andres. A lot of it is about commit message style, the
> use of fields, and so on. But I've also developed a check list for
> committing, knowing that there are a few classic mistakes that
> committers will make from time to time despite knowing better. These
> are worth checking against mechanically, IMV. Here are some actual
> examples from this document that I refer to:

Good list.

> * Do a dry run before really pushing by using --dry-run.

In addition to this, I'd recommend using 'git show' on the results of
the --dry-run, so that you see what you're really about to push.

Thanks!

Stephen

Attachment

pgsql-hackers by date:

Previous
From: Alvaro Hernandez
Date:
Subject: Re: [Proposal] Table-level Transparent Data Encryption (TDE) and KeyManagement Service (KMS)
Next
From: Alexander Korotkov
Date:
Subject: Re: [HACKERS] [PATCH] kNN for SP-GiST