Re: Portability concerns over pq_sendbyte? - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Portability concerns over pq_sendbyte?
Date
Msg-id 20180627094046.GE2667@paquier.xyz
Whole thread Raw
In response to Re: Portability concerns over pq_sendbyte?  (Andres Freund <andres@anarazel.de>)
List pgsql-hackers
On Tue, Jun 26, 2018 at 11:51:49PM -0700, Andres Freund wrote:
> Looking at surrounding code I found a few more oddities, but of older
> vintage:
> - pq_sendfloat4 uses an uint32 in the union, but float8 uses a int64.
> - same with pq_getmsgfloat[48]
> - pq_getmsgint64 returns a int64, should probably also be uint64
>
> Given they're practially harmless I'm inclined to only fix them in
> master?

Doing those three things on HEAD only looks like a good plan to me.  I
have not spotted more inconsistencies in pqformat.c.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Small fixes about backup history file in doc and pg_standby
Next
From: Rajkumar Raghuwanshi
Date:
Subject: alter index WITH ( storage_parameter = value [, ... ] ) for partition index.