Hello.
Good catch!
At Tue, 26 Jun 2018 17:47:52 +0900, Yugo Nagata <nagata@sraoss.co.jp> wrote in
<20180626174752.0ce505e3.nagata@sraoss.co.jp>
> Hi,
>
> While looking into the backup and recovery code, I found small documentation bugs.
> The documatation says that the backup history files can be requested for recovery,
> but it's not used by the system and not requested anymore since PG 9.0
> (commit 06f82b29616cd9effcaefd99c6b6e2e80697482f) and never be requested.
>
> Attached patch (doc_backup_history_file.patch) corrects the description about this.
>
> In addition, the current pg_standby still can handle a backup history file that are
> never requested. It is harmless but unnecessary code. Another attached patch
> (pg_standby.patch) removes this part of code.
The comment fix seems fine and they seem to be all occurances of
the word ".backup" in the context of recovery_command.
The definition of the symbol XLOG_BACKUP_LABEL is no longer
useful after your patch applied. Removing the symbol makes
XLOG_DATA and the variable nextWALFileName useless and finally we
can remove all branching using it.
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
