Postgres Pro
Downloads
Home   >   mailing lists

Re: Incorrect errno used with %m for backend code - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Incorrect errno used with %m for backend code
Date
Msg-id 20180625022614.GB1146@paquier.xyz
Whole thread Raw
In response to Re: Incorrect errno used with %m for backend code  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
Tree view 
On Sun, Jun 24, 2018 at 09:23:50PM +0900, Michael Paquier wrote:
> On Sun, Jun 24, 2018 at 09:22:01AM +0530, Ashutosh Sharma wrote:
>> Okay, I too had a quick look into the source code to see if there are
>> still some places where we could have missed to set an errno to ENOSPC
>> in case of write system call failure but, couldn't find any such place
>> in the code. The v2 version of patch looks good to me.
>
> Thanks for the review.  I'll try to wrap that tomorrow with proper
> patches for back-branches as things diverge a bit here and there.

Pushed down to 9.3.  All branches conflicted, and particularly in
pg_basebackup some write() calls have been moved around.
--
Michael
Attachment

pgsql-hackers by date:

Previous
From: Craig Ringer
Date:
Subject: Re: PATCH: backtraces for error messages
Next
From: Amit Langote
Date:
Subject: Re: postgresql_fdw doesn't handle defaults correctly