Re: pgsql: Fix for globals.c- c.h must come first - Mailing list pgsql-committers

From Bruce Momjian
Subject Re: pgsql: Fix for globals.c- c.h must come first
Date
Msg-id 20180619175834.GE3637@momjian.us
Whole thread Raw
In response to pgsql: Fix for globals.c- c.h must come first  (Stephen Frost <sfrost@snowman.net>)
Responses Re: pgsql: Fix for globals.c- c.h must come first  (Andres Freund <andres@anarazel.de>)
Re: pgsql: Fix for globals.c- c.h must come first  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-committers
On Sat, May 19, 2018 at 01:20:47AM +0000, Stephen Frost wrote:
> Fix for globals.c- c.h must come first
> 
> Commit da9b580 mistakenly put a system header before postgres.h (which
> includes c.h).  That can cause portability issues and broke (at least)
> builds with older Windows compilers.

I assume there is no way to add defined and checks to globals.c and c.h
to cause a compile error when this happens.

-- 
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

+ As you are, so once was I.  As I am, so you will be. +
+                      Ancient Roman grave inscription +


pgsql-committers by date:

Previous
From: Bruce Momjian
Date:
Subject: pgsql: doc: explain use of json_populate_record{set}()
Next
From: Andres Freund
Date:
Subject: Re: pgsql: Fix for globals.c- c.h must come first