Re: Portability concerns over pq_sendbyte? - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Portability concerns over pq_sendbyte?
Date
Msg-id 20180611052544.GC31877@paquier.xyz
Whole thread Raw
In response to Re: Portability concerns over pq_sendbyte?  (Alvaro Herrera <alvherre@2ndquadrant.com>)
Responses Re: Portability concerns over pq_sendbyte?
List pgsql-hackers
On Wed, Jun 06, 2018 at 12:27:58PM -0400, Alvaro Herrera wrote:
> Do you have an answer to this question?  Does anybody else?
>
> (My guts tell me it'd be better to change these routines to take
> unsigned values, without creating extra variants.  But guts frequently
> misspeak.)

My guts are telling me as well to not have more variants.  On top of
that it seems to me that we'd want to rename any new routines to include
"uint" in their name instead of "int", and for compatibility with past
code pq_sendint should not be touched.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Dilip Kumar
Date:
Subject: Re: Concurrency bug in UPDATE of partition-key
Next
From: Laurenz Albe
Date:
Subject: Re: SHOW ALL does not honor pg_read_all_settings membership