Postgres Pro
Downloads
Home   >   mailing lists

Re: SHOW ALL does not honor pg_read_all_settings membership - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: SHOW ALL does not honor pg_read_all_settings membership
Date
Msg-id 20180611013814.GF7066@paquier.xyz
Whole thread Raw
In response to Re: SHOW ALL does not honor pg_read_all_settings membership  (Alvaro Herrera <alvherre@2ndquadrant.com>)
List pgsql-hackers
Tree view 
On Fri, Jun 08, 2018 at 03:13:57PM -0400, Alvaro Herrera wrote:
> And I think this fixes it.

-    if (conf->source == PGC_S_FILE && superuser())
+    if (conf->source == PGC_S_FILE &&
+        is_member_of_role(GetUserId(), DEFAULT_ROLE_READ_ALL_SETTINGS))

Thanks Alvaro!  This bit in GetConfigOptionByNum() looks fine to me.
--
Michael
Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Loaded footgun open_datasync on Windows
Next
From: David Rowley
Date:
Subject: Re: why partition pruning doesn't work?