Re: Possible bug in logical replication. - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Possible bug in logical replication.
Date
Msg-id 20180611003756.GB7066@paquier.xyz
Whole thread Raw
In response to Re: Possible bug in logical replication.  (Simon Riggs <simon@2ndquadrant.com>)
Responses Re: Possible bug in logical replication.
List pgsql-hackers
On Thu, Jun 07, 2018 at 08:32:10AM +0100, Simon Riggs wrote:
> On 6 June 2018 at 17:22, Alvaro Herrera <alvherre@2ndquadrant.com> wrote:
>> This thread seems to have died down without any fix being proposed.
>> Simon, you own this open item.
>
> Thanks, will look.

Petr and I have found a couple of issues about the slot advance stuff on
this thread:
https://www.postgresql.org/message-id/20180525052805.GA15634%40paquier.xyz

The result is f731cfa, which, per my tests, is able to take care of this
issue as well as advancing first a slot to a WAL page boundary, and then
advancing it to the latest LSN available does not trigger any assertions
anymore.  It would be nice if there is a double-check though, so I am
letting this thread on the list of open items for now.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: pg_replication_slot_advance to return NULL instead of 0/0 ifslot not advanced
Next
From: Michael Paquier
Date:
Subject: Re: pgsql: Fix and document lock handling for in-memory replicationslot da