Re: Why is fncollation in FunctionCallInfoData rather than fmgr_info? - Mailing list pgsql-hackers

From Andres Freund
Subject Re: Why is fncollation in FunctionCallInfoData rather than fmgr_info?
Date
Msg-id 20180606231100.ypy7r3mazlyjqzd4@alap3.anarazel.de
Whole thread Raw
In response to Re: Why is fncollation in FunctionCallInfoData rather than fmgr_info?  (Andrew Gierth <andrew@tao11.riddles.org.uk>)
Responses Re: Why is fncollation in FunctionCallInfoData rather than fmgr_info?
List pgsql-hackers
Hi,

On 2018-06-06 21:25:14 +0100, Andrew Gierth wrote:
> >>>>> "Andres" == Andres Freund <andres@anarazel.de> writes:
> 
>  Andres> I think it's not unreasonable to think of it that way, but it's
>  Andres> really not how it is used today. In pretty much all cases the
>  Andres> collation is known and determined at the time fmgr_info() is
>  Andres> called (we also commonly reuse FunctionCallInfoData structs).
> 
> The obvious case which is not one of those "pretty much all cases" is
> where DirectFunctionCallN[Coll] is used - which turns out to be not all
> that unusual.

There the callsite just lives for just one call, I don't really see that
being an exception?

Greetings,

Andres Freund


pgsql-hackers by date:

Previous
From: Tomas Vondra
Date:
Subject: Re: POC: GROUP BY optimization
Next
From: Tom Lane
Date:
Subject: Re: Why is fncollation in FunctionCallInfoData rather than fmgr_info?