Re: behave of --create-slot option - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: behave of --create-slot option
Date
Msg-id 20180530180026.GB25072@paquier.xyz
Whole thread Raw
In response to Re: behave of --create-slot option  (Pavel Stehule <pavel.stehule@gmail.com>)
Responses Re: behave of --create-slot option  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
On Tue, May 29, 2018 at 09:21:00PM +0200, Pavel Stehule wrote:
> 2018-05-29 16:53 GMT+02:00 Euler Taveira <euler@timbira.com.br>:
>> If pg_basebackup failed for some other reason *after* the replication
>> slot was created (say, permission problem) then we should try to
>> cleanup the old slot. That should be the behavior if we want to try to
>> be idempotent ("try" because if we have a network problem it won't be
>> possible to remove the replication slot).
>
> It has sense for me

Hm.  There could be an argument for improving the user experience here
so as some cleanup is at least attempted except if --no-clean is defined
by the caller when --create-slot is used.  Do we want an open item for
this issue?
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Teodor Sigaev
Date:
Subject: Re: Few comments on commit 857f9c36 (skip full index scans )
Next
From: Adrien Nayrat
Date:
Subject: New GUC to sample log queries