Re: BUG #15105: OpenTransientFile() should be paired withCloseTransientFile() rather than close() - Mailing list pgsql-bugs

From Michael Paquier
Subject Re: BUG #15105: OpenTransientFile() should be paired withCloseTransientFile() rather than close()
Date
Msg-id 20180411032917.GK26769@paquier.xyz
Whole thread Raw
In response to Re: BUG #15105: OpenTransientFile() should be paired with CloseTransientFile() rather than close()  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-bugs
On Tue, Apr 10, 2018 at 06:40:43PM -0400, Tom Lane wrote:
> On closer inspection, such a cross-check wouldn't have helped find this
> particular mistake, because it was in an error exit path that's likely
> never been exercised by anybody, and certainly isn't hit in the regression
> tests.  Still, I think it'd be a good thing to add, and hence propose the
> attached patch.  (I've verified that the warning doesn't fire in "make
> check-world".)

Good idea.  +1 for your proposed patch.
--
Michael

Attachment

pgsql-bugs by date:

Previous
From: David Rowley
Date:
Subject: Re: power() function in Windows: "value out of range: underflow"
Next
From: Euler Taveira
Date:
Subject: Re: power() function in Windows: "value out of range: underflow"