Re: pgsql: Fix timing issue in new subscription truncate test - Mailing list pgsql-committers

From Andres Freund
Subject Re: pgsql: Fix timing issue in new subscription truncate test
Date
Msg-id 20180407175323.5ajmrsvvillht2ky@alap3.anarazel.de
Whole thread Raw
In response to Re: pgsql: Fix timing issue in new subscription truncate test  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-committers
Hi,

On 2018-04-07 13:31:53 -0400, Tom Lane wrote:
> Oh ... digging into that, it's because that test depends on hstore,
> which I hadn't installed.  How much is that dependency really
> buying us?

There's some separate logic for non-core datatypes, so it seems good to
test that. Hstore seems like a reasonable choice for it.


>  If there's a good reason to have it, we should
> (a) document the requirement in src/test/subscription/README,
> and (b) try to make the failure less obscure.  I do not really find
> this to be an acceptable spelling of "you didn't install hstore":

No argument there.

Greetings,

Andres Freund


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: Re: pgsql: Fix timing issue in new subscription truncate test
Next
From: Teodor Sigaev
Date:
Subject: pgsql: Add json(b)_to_tsvector function