Re: Change RangeVarGetRelidExtended() to take flags argument? - Mailing list pgsql-hackers

From Andres Freund
Subject Re: Change RangeVarGetRelidExtended() to take flags argument?
Date
Msg-id 20180330215545.3vvbxeqdyosaas65@alap3.anarazel.de
Whole thread Raw
In response to Re: Change RangeVarGetRelidExtended() to take flags argument?  ("Bossart, Nathan" <bossartn@amazon.com>)
List pgsql-hackers
Hi,

On 2018-03-30 17:08:26 +0000, Bossart, Nathan wrote:
> +typedef enum RelidOption
> +{
> +    RELID_MISSING_OK = 1 << 0,    /* don't error if relation doesn't exist */
> +    RELID_NOWAIT = 1 << 1        /* error if relation cannot be locked */
> +} RelidOption;

I don't like the Relid prefix here. RangeVarGetRelid deals with
*rangevars*, and returns a relation oid. ISTM it'd be more accurate to
call this RV_* or RVID_*. Counterarguments, preferences?

Other than that this looks good, and I plan to push it later today.

Andres


pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: Passing current_database to BackgroundWorkerInitializeConnection
Next
From: Jeremy Finzel
Date:
Subject: Re: Passing current_database to BackgroundWorkerInitializeConnection