Re: Failed to request an autovacuum work-item in silence - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: Failed to request an autovacuum work-item in silence
Date
Msg-id 20180308134656.4vp5uw3yaygadf5t@alvherre.pgsql
Whole thread Raw
In response to Re: Failed to request an autovacuum work-item in silence  (Masahiko Sawada <sawada.mshk@gmail.com>)
Responses Re: Failed to request an autovacuum work-item in silence  (Masahiko Sawada <sawada.mshk@gmail.com>)
List pgsql-hackers
Hi

I was thinking that the BRIN code requesting the workitem would print
the error message based on the return value.  There is no point to
returning a boolean indicator if the caller isn't going to do anything
with it ...  This means you don't need to convert the type to string in
autovacuum.c (which would defeat attempts at generalizing this code).

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


pgsql-hackers by date:

Previous
From: David Rowley
Date:
Subject: Re: ALTER TABLE ADD COLUMN fast default
Next
From: Julian Markwort
Date:
Subject: Re: [HACKERS] [FEATURE PATCH] pg_stat_statements with plans (v02)