2018-03 Commitfest Summary (Andres #1) - Mailing list pgsql-hackers

Hi,


Going through all non bugfix CF entries. Here's the summary for the
entries I could stomach tonight:

RFC: ready for committer
NR: needs review
WOA: waiting on author.

- pgbench - allow to store query results into variables

  RFC, has been worked on for a while.  Patch doesn't look 100% there,
  but not that far away from it either.

  A bit concerned that we're turning pgbench into a kitchen sink.


- pgbench - another attempt at tap test for time-related options

  NR, another attempt at adding tests. I'd personally boot this to the
  next fest, it's definitely not critical.


- Tab completion for SELECT in psql

  NR. Submitted in November.

  There is discussion around version compatibility of tab completion,
  which doesn't seem like we necessarily want to conclude this late in
  the cycle.

  I'd personally kick this this to the next fest.


- pgbench - add \if support

  RFC.

  I'm personally unconvinced we want this. Others on the thread seem
  unsure as well.


- pgbench - option to build using ppoll() for larger connection counts

  RFC. Seems like a reasonable idea. Looks like it needs a littlebit of
  tlc, but seems reasonable to get into 11.


- WIP: Pgbench Errors and serialization/deadlock retries

  WOA. Has been waiting since mid January.

  Boot to next, even though I really would like to have this feature.


- General purpose hashing func in pgbench

  RFC. Does mostly look ready, although I'm not sure the docs are at the
  right level of detail.

  I've similar concerns to earlier pgbench patches adding new
  operators, even though to a bit lower degree.


- pgbench - add ability to control random seed

  NR. Patch in current form has only been submitted in January. Seems to
  need some work, although not too much.

  Probably doable for 11, arguably a bit late.


- Find additional connection service files in pg_service.conf.d
  directory

  NR. Patch submitted for the first time in January.

  Boot to next, as bad as that is for new contributors. Did a short
  review.


- pgbench - break out initialization timing info by init phase

  WOA. Patch submitted for the first time in January. Not updated.

  Boot to next. IMO this shouldn't even *be* in this commitfest.


- csv output format for psql

  WOA. Patch submitted for the first time end of January.

  It's unclear to me whether we want this, there's not been much debate
  on that so far. The use case seems fairly minimal to me.

  I'd boot.


- Using base backup exclusion filters to reduce data transferred with pg_rewind

  NR. Nontrivial patchset, submittted in February.

  50 files changed, 588 insertions(+), 351 deletions(-)

  There've been no comments on the patch so far. There is new
  infrastructure.

  I'd boot.


- pgbench - allow to specify scale as a size

  NR. Submitted first time mid February.  There's debate about whether
  this is the right thing to do.

  I'd boot.


- pgbench - test whether a variable exists

  NR. Submitted first time mid February.

  Quoting from author:
  "Note that it is not really that useful for benchmarking, although it
  does not harm."

  I'd reject or boot.


- Support target_session_attrs=read-only and eliminate the added round-trip to detect session status.

  This is a new CF entry for a patch that's been removed from CF 2017-11
  that still doesn't apply anymore & hasn't been updated since
  October. Marked as returned.


- Parallel Dump to /dev/null

  NR: Allows directory dumps to /dev/null. Added to CF yesterday.

  As this is a late unreviewed nontrivial patch I'd argue this is too
  late, and we should move to the next CF. Message sent to thread.


- Comment of formdesc() forgets pg_subscription.

  NR. Trivial cleanup, will get resolved in some manner.


- Mention connection parameter "replication" in libpq section

  RFC. Doc fix. Should be doable. Commented.


- Correct the calculation of vm.nr_hugepages on Linux

  RFC. Doc fix. Should be doable. Commented.


- Updating parallel.sgml's treatment of parallel joins

  NR. Doc fix for commited change. Should get in.


- GUC for cleanup index threshold

  NR. Open for over a year.  Alexander Korotkov just tried to re-start
  discussion.

  Not quite sure if it's realistic unless somebody familiar with the
  code invests some time.


- default namespace support [for xpath]

  RFC.  Open for a while.  Nontrivial.

  I don't think it's quite RFC, comments and docs at least need a fair
  bit of polish.

  This probably deserves some attention.


- Vacuum: Update FSM more frequently

  NR. Older patch, but CF entry just created in January.

  Nice improvement, but it hasn't gotten a whole lot of review (starting
  end of Jan).  Possible, but somebody would need to be really
  interested.


- Test partition-wise join with partitioned tables containing default
  partition

  RFC. Tests for new feature. Should get in.


- Custom signals and handlers for extension

  WOA. Patch submitted 2017-12-22.

  There's not been much activity. This integrates in very fragile pieces
  of code, I'm not quite sure we want this in the current form. But
  feature is hugely useful for extensions. Will try to have a look in
  the next few days.

  Think it'd reasonable to not try to merge this in v11.


- TAP test module - PostgresClient

  NR. I'm unclear why this has a CF entry in the current fest.

  Suggested marking as returned with feedback in thread.


- taking stdbool.h into use

  RFC. Doesn't seem to be actual status. Patch by committer. Inquired on
  thread.


- (tiny) polish BGWorker example code and documentation

  NR. Minor code change. Should either commit or reject.


- Applying PMDK to WAL operations for persistent memory

  NR. Added in mid Jan.

  There is no way we can do anything actionable based on this thread in
  this CF. Commented on thread.

  Should move to next CF.


- Minor fixes for reloptions tests

  NR.

  Not sure if anybody will care. Could just apply.


- Failed to request an autovacuum work-item in silence

  NR. This seems more like a bugfix for recent code.

  Pinged Alvaro.

  Context:
  7526e10224f0792201e99631567bbe44492bbde4 : BRIN auto-summarization


- Control better SSL and LDAP test suites

  NR.  I can't get myself to care.


- Cast jsonb to numeric, int, float, bool

  RFC.  I'm have no opinion whether we want this, but it does not seem
  unreasonable and is fairly simpl. Might need a bit of error message
  polish.


- symlink installs

  NR.   Added last second.

  No idea whether we want this. Tom, you added behaviour this
  reverts. If you care ...


- amcheck heap verification

  NR. Been submitted for a while, a modicum of code review has been
  performed.

  Adds a fair bit of code:
   21 files changed, 1032 insertions(+), 64 deletions(-)

  but is low risk, being a readonly contrib module.

  Can probably committed if somebody has the energy.


- Enhancement of pg_stat_wal_receiver view to display connected host

  NR. Submitted late December. Has gotten some review.

  Seems like a reasonable idea.  Adds a new libpq function, so deserves
  some careful attention.


Ok, bedtime. Will continue tomorrow.  Committed a few patches along the
way.



Greetings,

Andres Freund