Re: ALTER TABLE ADD COLUMN fast default - Mailing list pgsql-hackers

From Andres Freund
Subject Re: ALTER TABLE ADD COLUMN fast default
Date
Msg-id 20180220200618.4tsle6uburodi2x7@alap3.anarazel.de
Whole thread Raw
In response to Re: ALTER TABLE ADD COLUMN fast default  (Tomas Vondra <tomas.vondra@2ndquadrant.com>)
Responses Re: ALTER TABLE ADD COLUMN fast default  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Hi,

On 2018-02-20 20:57:36 +0100, Tomas Vondra wrote:
> The question is how should the schema for TPC-H look like. Because if
> you just do the usual test without any ALTER TABLE ADD COLUMN, then you
> really won't get any difference at all. The fast default stuff will be
> completely "inactive".

Well, there'll still be changed behaviour due to the changed sizes of
structures and new out of line function calls. The deforming code is
quite sensitive to such changes.

I think just verifying that there's no meaningful effect with/without
the patch is good enough. As soon as there's actual new columns that
take advantage of the new functionality I think some degradation is fair
game, you got some benefit for it.

Greetings,

Andres Freund


pgsql-hackers by date:

Previous
From: Brent Kerby
Date:
Subject: Re: Option to ensure monotonic timestamps
Next
From: Tom Lane
Date:
Subject: Re: ALTER TABLE ADD COLUMN fast default