Re: pgsql: Add parallel-aware hash joins. - Mailing list pgsql-committers

From Andres Freund
Subject Re: pgsql: Add parallel-aware hash joins.
Date
Msg-id 20180124212916.aufzppm5bzg3oxav@alap3.anarazel.de
Whole thread Raw
In response to Re: pgsql: Add parallel-aware hash joins.  (Thomas Munro <thomas.munro@enterprisedb.com>)
Responses Re: pgsql: Add parallel-aware hash joins.
List pgsql-committers
Hi,

On 2018-01-22 23:17:47 +1300, Thomas Munro wrote:
> On Thu, Dec 28, 2017 at 5:26 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Here is a patch that halves the size of the test tables used.  I don't
> want them to be too small because I want some some real parallel
> processing at least sometimes.  On my slowest system with assertions
> enabled this brings "time make check" from ~37.5s to ~36.9s.  I'm a
> bit worried about choosing parameters that lead to instability across
> the buildfarm, until I make the size estimation code a bit smarter[1],
> so I tested a few variations that affect the alignment and size of
> things (-m32, -malign-double, --disable-atomics, --disable-spinlocks)
> and didn't see failures.  Does this pass repeatedly on gaur?

I'd say, let's just commit it and see?

Will do so soon if nobody protests.

Greetings,

Andres Freund


pgsql-committers by date:

Previous
From: Bruce Momjian
Date:
Subject: pgsql: doc: properly indent CREATE TRIGGER paragraph
Next
From: Robert Haas
Date:
Subject: pgsql: Avoid referencing off the end of subplan_partition_offsets.