Re: IndexTupleDSize macro seems redundant - Mailing list pgsql-hackers

From Stephen Frost
Subject Re: IndexTupleDSize macro seems redundant
Date
Msg-id 20180111203250.GR2416@tamriel.snowman.net
Whole thread Raw
In response to Re: IndexTupleDSize macro seems redundant  (Stephen Frost <sfrost@snowman.net>)
Responses Re: IndexTupleDSize macro seems redundant
Re: IndexTupleDSize macro seems redundant
List pgsql-hackers
Greetings Tom, Robert, Ildar, all,

* Stephen Frost (sfrost@snowman.net) wrote:
> That said, since it's not aligned, regardless of the what craziness the
> compiler might try to pull, we probably shouldn't go casting it
> to something that later hackers might think will be aligned, but we
> should add a comment to clarify that it's not aligned and that we can't
> act like it is.

Updated (combined) patch attached for review.  I went through and looked
again to make sure there weren't any cases of making an unaligned
pointer to a struct and didn't see any, and I added some comments to
_bt_restore_page().

Thanks!

Stephen

Attachment

pgsql-hackers by date:

Previous
From: Peter Geoghegan
Date:
Subject: Re: [HACKERS] Parallel tuplesort (for parallel B-Tree index creation)
Next
From: Alvaro Herrera
Date:
Subject: Re: unique indexes on partitioned tables