On 2018-01-05 18:57:55 -0500, Bruce Momjian wrote:
> On Fri, Jan 5, 2018 at 03:51:15PM -0800, Andres Freund wrote:
> > On 2018-01-05 14:20:59 -0500, Robert Haas wrote:
> > > On Fri, Jan 5, 2018 at 2:11 PM, Bruce Momjian <bruce@momjian.us> wrote:
> > > > pg_upgrade: simplify code layout in a few places
> > > >
> > > > Backpatch-through: 9.4 (9.3 didn't need improving)
> > >
> > > Hmm. We don't normally do things like this, because it breaks translatability.
> >
> > Also, leaving translatability aside, why was *any* of this backpatched?
> > Unless there's very good maintainability reasons we normally don't
> > backpatch minor refactorings?
>
> Tom has preferred that I backpatch all safe patches so we keep that code
> consistent so we can backpatch other things more easily.
I've a hard time believing this. Tom?
Greetings,
Andres Freund
