hash_seq_init in logicalrep_typmap_invalidate_cb is useless after your
patch. If you remove it, the function becomes empty, so why is it there
an invalidation callback at all?
Are we now leaking memory if types keep repeatedly being re-created in
the origin? I suppose it's not a common use pattern, but it'd be good
to avoid everlasting memleaks.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
