Re: pgsql: Provide overflow safe integer math inline functions. - Mailing list pgsql-committers

From Andres Freund
Subject Re: pgsql: Provide overflow safe integer math inline functions.
Date
Msg-id 20171213173524.rjs7b3ahsong5zko@alap3.anarazel.de
Whole thread Raw
In response to Re: pgsql: Provide overflow safe integer math inline functions.  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-committers
On 2017-12-13 09:37:25 -0500, Robert Haas wrote:
> On Wed, Dec 13, 2017 at 5:10 AM, Christoph Berg <myon@debian.org> wrote:
> > Re: Andres Freund 2017-12-13 <E1eOvQF-00075r-Cy@gemulon.postgresql.org>
> >> Provide overflow safe integer math inline functions.
> >
> > The new _overflow functions have buggy comments:
> >
> > /*
> >  * If a - b overflows, return true, otherwise store the result of a + b into
> >  * *result.                                                         ^ there
> 
> What's wrong with that?

After staring at it for a while, I seem to have partially mis-copied the
note for addition to the subtraction operation...

Greetings,

Andres Freund


pgsql-committers by date:

Previous
From: Peter Eisentraut
Date:
Subject: pgsql: Start a separate test suite for plpgsql
Next
From: Tom Lane
Date:
Subject: pgsql: Rethink MemoryContext creation to improve performance.