Re: [HACKERS] Re: [COMMITTERS] pgsql: Perform only oneReadControlFile() during startup. - Mailing list pgsql-hackers

From Andres Freund
Subject Re: [HACKERS] Re: [COMMITTERS] pgsql: Perform only oneReadControlFile() during startup.
Date
Msg-id 20170917080752.rcmihzfmgbeuqjk2@alap3.anarazel.de
Whole thread Raw
In response to Re: [HACKERS] Re: [COMMITTERS] pgsql: Perform only oneReadControlFile() during startup.  (Andres Freund <andres@anarazel.de>)
Responses Re: [HACKERS] Re: [COMMITTERS] pgsql: Perform only oneReadControlFile() during startup.  (Andres Freund <andres@anarazel.de>)
List pgsql-hackers
On 2017-09-16 13:27:05 -0700, Andres Freund wrote:
> > This does not seem like a problem that justifies a system-wide change
> > that's much more delicate than you thought.
> 
> We need one more initialization call during crash-restart - that doesn't
> seem particularly hard a fix.

FWIW, attached is that simple fix. Not quite ready for commit - needs
more comments, thoughts and a glass of wine less to commit.

I'll try to come up with a tap test that tests crash restarts tomorrow -
not sure if there's a decent way to trigger one on windows without
writing a C function. Will play around with that tomorrow.

- Andres

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Attachment

pgsql-hackers by date:

Previous
From: Andreas Karlsson
Date:
Subject: Re: [HACKERS] postgres_fdw super user checks
Next
From: Oleg Bartunov
Date:
Subject: Re: [HACKERS] SQL/JSON in PostgreSQL