Hello, (does this seem to be a top post?)
The CF status of this patch turned into "Waiting on Author" by
automated CI checking. However, I still don't get any error even
on the current master (69835bc) after make distclean. Also I
don't see any difference between the "problematic" patch and my
working branch has nothing different other than patching line
shifts. (So I haven't post a new one.)
I looked on the location heapam.c:2502 where the CI complains at
in my working branch and I found a different code with the
complaint.
https://travis-ci.org/postgresql-cfbot/postgresql/builds/274777750
1363 heapam.c:2502:18: error: ‘HEAP_INSERT_SKIP_WAL’ undeclared (first use in this function)
1364 if (!(options & HEAP_INSERT_SKIP_WAL) && RelationNeedsWAL(relation))
heapam.c:2502@work branch
2502: /* XLOG stuff */
2503: if (BufferNeedsWAL(relation, buffer))
So I conclude that the CI mechinery failed to applly the patch
correctly.
At Thu, 13 Apr 2017 15:29:35 +0900 (Tokyo Standard Time), Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp> wrote in
<20170413.152935.100104316.horiguchi.kyotaro@lab.ntt.co.jp>
> > > > I'll post new patch in this way soon.
> > >
> > > Here it is.
> >
> > It contained tariling space and missing test script. This is the
> > correct patch.
> >
> > > - Relation has new members no_pending_sync and pending_sync that
> > > works as instant cache of an entry in pendingSync hash.
> > >
> > > - Commit-time synchronizing is restored as Michael's patch.
> > >
> > > - If relfilenode is replaced, pending_sync for the old node is
> > > removed. Anyway this is ignored on abort and meaningless on
> > > commit.
> > >
> > > - TAP test is renamed to 012 since some new files have been added.
> > >
> > > Accessing pending sync hash occured on every calling of
> > > HeapNeedsWAL() (per insertion/update/freeze of a tuple) if any of
> > > accessing relations has pending sync. Almost of them are
> > > eliminated as the result.
regards,
--
Kyotaro Horiguchi
NTT Open Source Software Center
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
