On 2017-08-11 13:26:29 -0700, Andres Freund wrote:
> On 2017-08-11 16:20:51 -0400, Tom Lane wrote:
> > I wrote:
> > > So, apparently somebody wrote ExecReScanGatherMerge, but never bothered
> > > to plug it into ExecReScan. From which we may draw depressing conclusions
> > > about how much it's been tested.
> >
> > While I'm bitching ... the code coverage report at
> >
> > https://coverage.postgresql.org/src/backend/executor/nodeGatherMerge.c.gcov.html
> >
> > also leaves one with less than a warm feeling about the extent of test
> > coverage on this file. heap_compare_slots isn't invoked even once?
>
> I complained about this before at
> http://archives.postgresql.org/message-id/20170401022605.4wag26gtyzhny7ue%40alap3.anarazel.de
> but I just noticed that Rushabh appears to have sent a patch adding
> coverage. Missed that somehow, will apply.
And pushed (to both 10 and master).
- Andres
--
Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-bugs