Postgres Pro
Downloads
Home   >   mailing lists

Re: [HACKERS] Missing comment for max_logical_replication_workersin postgresql.conf.sample - Mailing list pgsql-hackers

From Yugo Nagata
Subject Re: [HACKERS] Missing comment for max_logical_replication_workersin postgresql.conf.sample
Date
Msg-id 20170728010109.84b82be6.nagata@sraoss.co.jp
Whole thread Raw
In response to Re: [HACKERS] Missing comment for max_logical_replication_workers in postgresql.conf.sample  (Masahiko Sawada <sawada.mshk@gmail.com>)
Responses Re: [HACKERS] Missing comment for max_logical_replication_workersin postgresql.conf.sample
List pgsql-hackers
Tree view 
On Thu, 27 Jul 2017 14:38:29 +0900
Masahiko Sawada <sawada.mshk@gmail.com> wrote:

> On Thu, Jul 27, 2017 at 10:14 AM, Yugo Nagata <nagata@sraoss.co.jp> wrote:
> > Hi,
> >
> > I found that postgresql.conf.sample is missing a comment
> > to note that changing max_logical_replication_workers requires
> > restart of the server.
> >
> > Other such parameters has the comments, so I think the new
> > parameter also needs this. Attached is a simple patch to fix
> > this.
> >
> 
> Good point. Similarly, dynamic_shared_memory_type and event_source are
> required restarting to change but are not mentioned in
> postgresql.conf.sample. Should we add a comment as well?

I think so. The updated patch is attached.

> 
> Regards,
> 
> --
> Masahiko Sawada
> NIPPON TELEGRAPH AND TELEPHONE CORPORATION
> NTT Open Source Software Center


-- 
Yugo Nagata <nagata@sraoss.co.jp>

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: [HACKERS] pg_upgrade failed with error - ERROR: column "a" inchild table must be marked NOT NULL
Next
From: Jeff Janes
Date:
Subject: [HACKERS] tab completion for "create user mapping for"