Postgres Pro
Downloads
Home   >   mailing lists

Re: [HACKERS] Incorrect comment of XLByteToSeg() andXLByteToPrevSeg() - Mailing list pgsql-hackers

From Tatsuo Ishii
Subject Re: [HACKERS] Incorrect comment of XLByteToSeg() andXLByteToPrevSeg()
Date
Msg-id 20170728.120301.1977408759697450997.t-ishii@sraoss.co.jp
Whole thread Raw
In response to [HACKERS] Incorrect comment of XLByteToSeg() and XLByteToPrevSeg()  (Yugo Nagata <nagata@sraoss.co.jp>)
Responses Re: [HACKERS] Incorrect comment of XLByteToSeg() andXLByteToPrevSeg()
List pgsql-hackers
Tree view 
> I found a type in the comment for XLByteToSeg() and XLByteToPrevSeg().
> This says "Compute ID and segment from an XLogRecPtr", but these
> macros compute only segment numbers. I think "Compute a segment number
> from an XLogRecPtr" is correct.
> 
> The definition of these macros were modified by the following commit,
> but the comment were not.
> 
> commit dfda6ebaec6763090fb78b458a979b558c50b39b
> Author: Heikki Linnakangas <heikki.linnakangas@iki.fi>
> Date:   Sun Jun 24 18:06:38 2012 +0300

Thanks for the patch. Looks good to me. I will commit/push into all
supported branches if there's no objection.

Best regards,
--
Tatsuo Ishii
SRA OSS, Inc. Japan
English: http://www.sraoss.co.jp/index_en.php
Japanese:http://www.sraoss.co.jp

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: [HACKERS] PL_stashcache, or, what's our minimum Perl version?
Next
From: Craig Ringer
Date:
Subject: Re: [HACKERS] On Complex Source Code Reading Strategy