Postgres Pro
Downloads
Home   >   mailing lists

Re: [HACKERS] Locale dependency in new postgres_fdw test - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: [HACKERS] Locale dependency in new postgres_fdw test
Date
Msg-id 20170721193528.ao3adbv4cvesywdf@alvherre.pgsql
Whole thread Raw
In response to [HACKERS] Locale dependency in new postgres_fdw test  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: [HACKERS] Locale dependency in new postgres_fdw test
List pgsql-hackers
Tree view 
Tom Lane wrote:

> We could stabilize this test result by forcing lc_messages = C in
> the foreign server options.  However, that would lose regression
> coverage of situations where the remote locale is different, which
> doesn't seem like a terribly good thing.

I don't understand what is the benefit of having a different locale
setting if there's no way that the test would pass except with a very
specific locale.  In other words, what coverage are we really losing by
going this route?

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

pgsql-hackers by date:

Previous
From: Fabrízio de Royes Mello
Date:
Subject: Re: [HACKERS] [PATCH] A hook for session start
Next
From: "Joshua D. Drake"
Date:
Subject: [HACKERS] possible effective_io_concurrency performance regression