Re: [HACKERS] Race-like failure in recovery/t/009_twophase.pl - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: [HACKERS] Race-like failure in recovery/t/009_twophase.pl
Date
Msg-id 20170702150030.hxiw6br44b5vr6zk@alvherre.pgsql
Whole thread Raw
In response to [HACKERS] Race-like failure in recovery/t/009_twophase.pl  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: [HACKERS] Race-like failure in recovery/t/009_twophase.pl
List pgsql-hackers
Tom Lane wrote:

> Part of the reason I'm confused is that the programming technique
> being used in 009_twophase.pl, namely doing
> 
>     ($node_master, $node_slave) = ($node_slave, $node_master);
> 
> and then working with the reversed variable names, is ENTIRELY TOO CUTE
> FOR ITS OWN GOOD.

This is my fault.  I noticed this in the submitted test (and was pretty
confused about it too) when I reviewed it for commit, but somehow it
didn't reach my threshold to require a rewrite.  I'll fix it sometime
during the week.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: [HACKERS] UPDATE of partition key
Next
From: Tom Lane
Date:
Subject: Re: [HACKERS] Race-like failure in recovery/t/009_twophase.pl