Re: [HACKERS] shift_sjis_2004 related autority files are remaining - Mailing list pgsql-hackers

From Tatsuo Ishii
Subject Re: [HACKERS] shift_sjis_2004 related autority files are remaining
Date
Msg-id 20170623.093952.1972889039120283924.t-ishii@sraoss.co.jp
Whole thread Raw
In response to Re: [HACKERS] shift_sjis_2004 related autority files are remaining  (Michael Paquier <michael.paquier@gmail.com>)
Responses Re: [HACKERS] shift_sjis_2004 related autority files are remaining
List pgsql-hackers
>> Why do you believe so?
> 
> Unicode/Makefile includes that:
> euc-jis-2004-std.txt sjis-0213-2004-std.txt:
>         $(DOWNLOAD) http://x0213.org/codetable/$(@F)
> 
> So those files ought to be downloaded when rebuilding the maps, and
> they should not be in the tree. In short, I think that Horiguchi-san
> is right. On top of the two pointed out by Horiguchi-san,
> gb-18030-2000.xml should not be in the tree.

I think we should keep the original .txt files because:

- It allows to track the changes in the original file if we decide to change the map files.

- The site http://x0213.org/ may disappear in the future. If that happens, we will lose track data how we create the
mapfiles.
 

I believe we'd better to follow the same way how src/timezone keeps
the original timezone data.

Above reasoning will not valid if we have a way to reconstruct the
original txt files from the map files, I doubt it's worth the
trouble to create such tools however.

Best regards,
--
Tatsuo Ishii
SRA OSS, Inc. Japan
English: http://www.sraoss.co.jp/index_en.php
Japanese:http://www.sraoss.co.jp



pgsql-hackers by date:

Previous
From: Amit Langote
Date:
Subject: Re: [HACKERS] Fix comment in xlog.c
Next
From: Michael Paquier
Date:
Subject: Re: [HACKERS] shift_sjis_2004 related autority files are remaining