Re: [HACKERS] shm_toc_lookup API - Mailing list pgsql-hackers

From Andres Freund
Subject Re: [HACKERS] shm_toc_lookup API
Date
Msg-id 20170605191005.hi2j2wfw2g3aucdq@alap3.anarazel.de
Whole thread Raw
In response to Re: [HACKERS] shm_toc_lookup API  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On 2017-06-05 15:06:06 -0400, Tom Lane wrote:
> Andres Freund <andres@anarazel.de> writes:
> > On 2017-06-05 14:57:10 -0400, Tom Lane wrote:
> >> Meh.  Without volatile, I think that the compiler would be within its
> >> rights to elide the nentry local variable and re-fetch toc->toc_nentry
> >> each time through the loop.
> 
> > I don't think that's true.
> 
> Perhaps not, but I'm not quite convinced.  Anyway it doesn't matter,
> at least not here.

If not, we have a bunch of bugs in other files.  So if there are
concerns, we should better resolve them.

- Andres



pgsql-hackers by date:

Previous
From: Andrew Dunstan
Date:
Subject: Re: [HACKERS] PROVE_FLAGS
Next
From: "Jim Van Fleet"
Date:
Subject: [HACKERS] HACKERS[PROPOSAL] split ProcArrayLock into multiple parts