Re: [HACKERS] 10beta1/m68k: static assertion failed: "MAXALIGN toosmall to fit int32" - Mailing list pgsql-hackers

From Andres Freund
Subject Re: [HACKERS] 10beta1/m68k: static assertion failed: "MAXALIGN toosmall to fit int32"
Date
Msg-id 20170518160042.tvojbdqwmzv4xwfn@alap3.anarazel.de
Whole thread Raw
In response to Re: [HACKERS] 10beta1/m68k: static assertion failed: "MAXALIGN toosmall to fit int32"  (Heikki Linnakangas <hlinnaka@iki.fi>)
List pgsql-hackers
On 2017-05-18 10:48:48 +0300, Heikki Linnakangas wrote:
> If that's all that prevents it from working, by all means let's fix it. I
> think this should do it, although I don't have a system to test it on:

Yes, that's what I thought about doing too.


> It adds a few instructions to check that on all platforms, unless the
> compiler can optimize that away, but this is not performance critical.

Yea, that seems fairly harmless. Context creation is much more
heavyweight than those 2-3 instructions.


> I'll commit that, barring objections. If you can verify that it fixes the
> problem before that, that'd be great, otherwise I guess we'll find out some
> time after the commit.

lgtm.


Thanks!

Andres



pgsql-hackers by date:

Previous
From: Marina Polyakova
Date:
Subject: Re: [HACKERS] WIP Patch: Precalculate stable functions,infrastructure v1
Next
From: Dilip Kumar
Date:
Subject: Re: [HACKERS] [POC] hash partitioning