[HACKERS] Removing select(2) based latch (was Unportable implementation ofbackground worker start) - Mailing list pgsql-hackers

From Andres Freund
Subject [HACKERS] Removing select(2) based latch (was Unportable implementation ofbackground worker start)
Date
Msg-id 20170420003611.7r2sdvehesdyiz2i@alap3.anarazel.de
Whole thread Raw
Responses Re: [HACKERS] Removing select(2) based latch (was Unportable implementation of background worker start)  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On 2017-04-19 20:06:05 -0400, Tom Lane wrote:
> > BTW, we IIRC had discussed removing the select() backed latch
> > implementation in this release.  I'll try to dig up that discussion.
>
> Might be sensible.  Even my pet dinosaurs have poll(2).

I can't find the discussion anymore, but I'm fairly sure we did discuss
that.  So here's a new one.

> We should check the buildfarm to see if the select() implementation is
> being tested at all.

I verified it's currently not (unless I made a mistake):
pgbfprod=>
select bs.name, snapshot
FROM buildsystems bs, lateral (   SELECT * FROM build_status_log bsl   WHERE bs.name = bsl.sysname AND log_stage =
'configure.log'  ORDER BY bsl.sysname, bsl.snapshot desc, bsl.log_stage limit 1) bsl2   WHERE       log_text NOT LIKE
'%noconfigure step for MSCV%'       AND log_text NOT LIKE '%checking for poll... yes%' order by snapshot desc;  name
|     snapshot
 
-----------+---------------------frogmouth | 2017-04-19 00:32:32jacana    | 2017-04-19 00:00:58narwhal   | 2017-04-18
07:00:01
(3 rows)

and those three animals are windows, and thus use the windows
implementation.

This actually seems to suggest that no animal, including dead ones,
didn't have poll(2) support at the time of their last run...

- Andres



pgsql-hackers by date:

Previous
From: Kyotaro HORIGUCHI
Date:
Subject: Re: [HACKERS] Quorum commit for multiple synchronous replication.
Next
From: Michael Paquier
Date:
Subject: Re: [HACKERS] Continuous buildfarm failures on hamster with bin-check