Re: [HACKERS] GCC 7 warnings - Mailing list pgsql-hackers

From Andres Freund
Subject Re: [HACKERS] GCC 7 warnings
Date
Msg-id 20170410161007.msbvliyv447qtbez@alap3.anarazel.de
Whole thread Raw
In response to [HACKERS] GCC 7 warnings  (Peter Eisentraut <peter.eisentraut@2ndquadrant.com>)
Responses Re: [HACKERS] GCC 7 warnings  (Andres Freund <andres@anarazel.de>)
List pgsql-hackers
Hi,

On 2017-04-10 11:03:23 -0400, Peter Eisentraut wrote:
> The release of GCC 7 is approaching [0], and the number of warnings in
> PostgreSQL has gone up since we last looked [1].  Output attached.  (My
> version is 7.0.1 20170408.)
> 
> Most of the issues have to do with concatenating two or more strings of
> potential size MAXPGPATH into another buffer of size MAXPGPATH, which
> could lead to truncation.

Hm, interesting - I don't see this with
gcc-7 (Debian 7-20170407-1) 7.0.1 20170407 (experimental) [trunk revision 246759]
although I do recall having seen them at some point.  Not sure what's up
there.

I've to add -Wno-implicit-fallthrough to avoid noisyness, though.

Regards,

Andres



pgsql-hackers by date:

Previous
From: Ildar Musin
Date:
Subject: [HACKERS] Repetitive code in RI triggers
Next
From: Andres Freund
Date:
Subject: Re: [HACKERS] GCC 7 warnings